Update link selector to format links automatically #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link selector is working correctly, as it's currently set to type="url" however Notion has this set to type="text" meaning browser validation isn't run on the input to check it is a valid URL. This means in notion typing google.com will link to http://google.com and allow the domain to handle http > https redirection. I have added a snippet to the form submission which will trim the string and then append http:// if it doesn't start with it already as well as changing the type to text on the input field.
|
@AidanDaniel97 is attempting to deploy a commit to the Elegance Team on Vercel. A member of the Team first needs to authorize it. |
|
Fantastic idea! Replaced this with a utility function I used in https://github.com/steven-tey/dub but other than that, LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link selector is working correctly, as it's currently set to type="url" however Notion has this set to type="text" meaning browser validation isn't run on the input to check it is a valid URL. This means in notion typing google.com will link to http://google.com and allow the domain to handle http > https redirection. I have added a snippet to the form submission which will trim the string and then append http:// if it doesn't start with it already as well as changing the type to text on the input field.
This may be a personal preference and is not exactly the desired functionality.