Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use more general type for extensions option #171

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

tjwelde
Copy link
Contributor

@tjwelde tjwelde commented Sep 22, 2023

This PR fixes an issue, where it was not possible type-wise to add a Mark extension.

An alternative would be to use EditorOptions['extensions']

@vercel
Copy link

vercel bot commented Sep 22, 2023

@tjwelde is attempting to deploy a commit to the Elegance Team on Vercel.

A member of the Team first needs to authorize it.

@steven-tey
Copy link
Owner

Great idea! :ty-heart:

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
novel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:26pm

@steven-tey steven-tey merged commit d1d5ff8 into steven-tey:main Oct 3, 2023
3 checks passed
@tjwelde tjwelde deleted the tw-fix-extensions-type branch October 5, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants