You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now the Downloader() object uses recursion to iterate through the list. This is problematic because it will lead to a very large call stack unless you use a setImmediate() to break out of it (see: commit 747ce13).
I do not like the setImmediate() approach because it feels like a code smell. So this object needs to be refactored to either replace the recursion with some flavor of simple iteration or the recursion needs to be implemented in such a way that it wont negatively impact the call stack or memory usage.
The text was updated successfully, but these errors were encountered:
stevenbenner
changed the title
Refactor Downloader() to fix or remove recursion.
Refactor Downloader() to fix or remove recursion.
Mar 22, 2014
stevenbenner
changed the title
Refactor Downloader() to fix or remove recursion.
Refactor Downloader() to fix or remove recursion.
Mar 22, 2014
Right now the
Downloader()
object uses recursion to iterate through the list. This is problematic because it will lead to a very large call stack unless you use asetImmediate()
to break out of it (see: commit 747ce13).I do not like the
setImmediate()
approach because it feels like a code smell. So this object needs to be refactored to either replace the recursion with some flavor of simple iteration or the recursion needs to be implemented in such a way that it wont negatively impact the call stack or memory usage.The text was updated successfully, but these errors were encountered: