-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple editable areas in a single document #195
Conversation
…ripts load string-based scripts independently.
…kupEditable protocol
Conflicts: MarkupEditor/MarkupCoordinator.swift MarkupEditor/MarkupWKWebView.swift MarkupEditor/MarkupWKWebViewRepresentable.swift
…in main as part of demo
…itor and look up actions from buttons
…ng to proceed async without serializing
Hello @stevengharris Actually i've an issue with a multiple instances of MarkupEditor and the MU.getSelectionState. |
I am using a branch with these changes in an app I'm working on, so I was waiting until I was surer about it being complete and not break anything the tests don't cover. I'm feeling pretty good on both of those fronts, so I can merge soon. Thanks for letting me know you are interested in it. I am not sure if you saw the discussion I opened about it. I also need to provide some documentation :-) I'm not sure it's going to address your problem, though. In this approach, there is still one "editor" div that contains everything, and selection changes anywhere within it still call back to the one MarkupCoordinator for the view which in turn will invoke the delegate methods for the delegate that is assigned to the view. If you use the same delegate for multiple views (which I would do, a superview being the delegate for the MarkupWKWebViews it holds), then you have to filter the callbacks based on which view they apply to. On the other hand, if you want to or can use a single MarkupWebView with multiple editable areas, then this PR will definitely let you do that, since it will include the ID of the div being edited in the callback. |
No description provided.