-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct deprecated function #257
Conversation
My SymPy.jl failed to build with this warning: ``` julia> using SymPy WARNING: get_bigfloat_precision() is deprecated, use precision(BigFloat) instead. [inlined code] from ./error.jl:26 in depwarn(::ASCIIString, ::Symbol) at ./deprecated.jl:64 in get_bigfloat_precision() at ./deprecated.jl:50 in mpmath_init() at /home/roger/.julia/v0.5/PyCall/src/conversions.jl:610 in init_mpmath() at /home/roger/.julia/v0.5/SymPy/src/mpmath.jl:43 in __init__() at /home/roger/.julia/v0.5/SymPy/src/SymPy.jl:315 in _require_from_serialized(::Int64, ::Symbol, ::ASCIIString, ::Bool) at ./loading.jl:165 in _require_from_serialized(::Int64, ::Symbol, ::Bool) at ./loading.jl:193 in require(::Symbol) at ./loading.jl:323 in eval(::Module, ::Any) at ./boot.jl:237 while loading no file, in expression starting on line 0 ``` After correct this line, it somehow works just fine.
That's odd, a deprecation warning should cause a build failure... |
You need to edit the REQUIRE file to increase the required Compat version to 0.7.10 (which is when the compatibility for |
Looks good to merge, can you do a |
You need to do https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/ |
Thanks and sorry, does it work now? |
@Roger-luo: No, you'll notice at the top of the PR that it is listed as 16 commits. The goal of squashing is to combine it into a single commit, so that the PR says "1 commit". |
Also, for some reason this PR includes other unrelated commits from the tree, so probably you made a mistake in the rebase. It might be easiest to just start with a clean branch and re-apply your patch. |
sure |
My SymPy.jl failed to build with this warning:
After correct this line, it somehow works just fine.