Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct deprecated function #257

Closed
wants to merge 16 commits into from
Closed

correct deprecated function #257

wants to merge 16 commits into from

Conversation

Roger-luo
Copy link

My SymPy.jl failed to build with this warning:

julia> using SymPy
WARNING: get_bigfloat_precision() is deprecated, use precision(BigFloat) instead.
 [inlined code] from ./error.jl:26
 in depwarn(::ASCIIString, ::Symbol) at ./deprecated.jl:64
 in get_bigfloat_precision() at ./deprecated.jl:50
 in mpmath_init() at /home/roger/.julia/v0.5/PyCall/src/conversions.jl:610
 in init_mpmath() at /home/roger/.julia/v0.5/SymPy/src/mpmath.jl:43
 in __init__() at /home/roger/.julia/v0.5/SymPy/src/SymPy.jl:315
 in _require_from_serialized(::Int64, ::Symbol, ::ASCIIString, ::Bool) at ./loading.jl:165
 in _require_from_serialized(::Int64, ::Symbol, ::Bool) at ./loading.jl:193
 in require(::Symbol) at ./loading.jl:323
 in eval(::Module, ::Any) at ./boot.jl:237
while loading no file, in expression starting on line 0

After correct this line, it somehow works just fine.

My SymPy.jl failed to build with this warning:

```
julia> using SymPy
WARNING: get_bigfloat_precision() is deprecated, use precision(BigFloat) instead.
 [inlined code] from ./error.jl:26
 in depwarn(::ASCIIString, ::Symbol) at ./deprecated.jl:64
 in get_bigfloat_precision() at ./deprecated.jl:50
 in mpmath_init() at /home/roger/.julia/v0.5/PyCall/src/conversions.jl:610
 in init_mpmath() at /home/roger/.julia/v0.5/SymPy/src/mpmath.jl:43
 in __init__() at /home/roger/.julia/v0.5/SymPy/src/SymPy.jl:315
 in _require_from_serialized(::Int64, ::Symbol, ::ASCIIString, ::Bool) at ./loading.jl:165
 in _require_from_serialized(::Int64, ::Symbol, ::Bool) at ./loading.jl:193
 in require(::Symbol) at ./loading.jl:323
 in eval(::Module, ::Any) at ./boot.jl:237
while loading no file, in expression starting on line 0
```

After correct this line, it somehow works just fine.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.695% when pulling aaec6d7 on Roger-luo:patch-1 into 6b9d577 on stevengj:master.

@stevengj
Copy link
Member

stevengj commented Apr 7, 2016

That's odd, a deprecation warning should cause a build failure...

@stevengj
Copy link
Member

stevengj commented Apr 7, 2016

You need to edit the REQUIRE file to increase the required Compat version to 0.7.10 (which is when the compatibility for get_bigfloat_precision was introduced).

@stevengj
Copy link
Member

stevengj commented Apr 8, 2016

Looks good to merge, can you do a git rebase followed by a forced push, to squash this into a single commit?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.594% when pulling c492ed2 on Roger-luo:patch-1 into e5c834f on stevengj:master.

@stevengj
Copy link
Member

You need to do git rebase -i to squash the commits into a single commit. See e.g.:

https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/

@Roger-luo
Copy link
Author

Thanks and sorry, does it work now?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.594% when pulling 376ac7c on Roger-luo:patch-1 into e5c834f on stevengj:master.

@stevengj
Copy link
Member

@Roger-luo: No, you'll notice at the top of the PR that it is listed as 16 commits. The goal of squashing is to combine it into a single commit, so that the PR says "1 commit".

@stevengj
Copy link
Member

Also, for some reason this PR includes other unrelated commits from the tree, so probably you made a mistake in the rebase. It might be easiest to just start with a clean branch and re-apply your patch.

@Roger-luo
Copy link
Author

sure

@Roger-luo Roger-luo closed this Apr 13, 2016
@Roger-luo Roger-luo deleted the patch-1 branch April 13, 2016 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants