-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LegacyStrings for julia 0.5 compatability #302
Conversation
I just realized that the travis config still relies on the staticfloat PPA, which is not maintained and won't give us a recent julia 0.5 build. I think that explains the CI errors. I'll try to figure out what to do about the travis stuff. |
This should not be needed with PyCall master, thanks to cd80a6e |
See also #295 |
Ah, I had tried |
@stevengj Could you tag a new version? Would be really helpful to have a tagged version that runs on 0.5 RC0 so that downstream packages can more easily be brought in shape for 0.5. If that version still has deprecation warnings, no problem, but having something that doesn't error out would be great. |
Yeah, I'm planning on tagging new versions of a bunch of my packages in the next couple of days. |
Cool. I think PyCall especially would help. The downstream packages really need a tagged version that works on travis and appveyor to get their julia 0.5 porting working. I actually don't need a version that doesn't throw deprecation warnings, from my point of view just a tag on the current master would already help a great deal. The deprecation warnings could be fixed later, they don't really stop downstream packages from getting their stuff in order. |
This should make things run on current julia 0.5 builds.