Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LegacyStrings for julia 0.5 compatability #302

Closed
wants to merge 1 commit into from

Conversation

davidanthoff
Copy link
Contributor

This should make things run on current julia 0.5 builds.

@coveralls
Copy link

coveralls commented Aug 2, 2016

Coverage Status

Coverage decreased (-58.3%) to 0.0% when pulling 7c23be6 on davidanthoff:legacystrings into 494f831 on stevengj:master.

@davidanthoff
Copy link
Contributor Author

I just realized that the travis config still relies on the staticfloat PPA, which is not maintained and won't give us a recent julia 0.5 build. I think that explains the CI errors. I'll try to figure out what to do about the travis stuff.

@stevengj
Copy link
Member

stevengj commented Aug 2, 2016

This should not be needed with PyCall master, thanks to cd80a6e

@stevengj stevengj closed this Aug 2, 2016
@stevengj
Copy link
Member

stevengj commented Aug 2, 2016

See also #295

@davidanthoff davidanthoff deleted the legacystrings branch August 2, 2016 04:42
@davidanthoff
Copy link
Contributor Author

Ah, I had tried master but hadn't run Pkg.build.

@davidanthoff
Copy link
Contributor Author

@stevengj Could you tag a new version? Would be really helpful to have a tagged version that runs on 0.5 RC0 so that downstream packages can more easily be brought in shape for 0.5. If that version still has deprecation warnings, no problem, but having something that doesn't error out would be great.

@stevengj
Copy link
Member

stevengj commented Aug 2, 2016

Yeah, I'm planning on tagging new versions of a bunch of my packages in the next couple of days.

@davidanthoff
Copy link
Contributor Author

Cool. I think PyCall especially would help. The downstream packages really need a tagged version that works on travis and appveyor to get their julia 0.5 porting working. I actually don't need a version that doesn't throw deprecation warnings, from my point of view just a tag on the current master would already help a great deal. The deprecation warnings could be fixed later, they don't really stop downstream packages from getting their stuff in order.

@stevengj
Copy link
Member

stevengj commented Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants