updates to ensure correct calculation of eigenmode coefficients with symmetries #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e presence of symmetries
stevengj
reviewed
Jul 12, 2018
src/mpb.cpp
Outdated
| @@ -634,8 +634,8 @@ void fields::get_eigenmode_coefficients(dft_flux flux, | |||
| if (d==NO_DIRECTION) | |||
| abort("cannot determine normal direction in get_eigenmode_coefficients"); | |||
|
|
|||
| if (S.multiplicity() > 1) | |||
| abort("symmetries are not yet supported in get_eigenmode_coefficients"); | |||
| //if (S.multiplicity() > 1) | |||
There was a problem hiding this comment.
Can we save the value of use_symmetry in the dft_flux object and still abort if (use_symmetry && S.multiplicity() > 1), i.e. in case an ordinary add_dft_flux was used?
…nmode_coefficients() if set incorrectly
|
cc @ChristopherHogan for a Python API. |
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
…symmetries (NanoComp#417) * updates to ensure correct calculation of eigenmode coefficients in the presence of symmetries * store use_symmetry flag in dft_flux structure and abort from get_eigenmode_coefficients() if set incorrectly * Update Makefile.am
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only API modification is the addition of a new method
fields::add_mode_monitorwith the same calling convention asadd_dft_flux.This instantiates adft_fluxobject in which symmetry reduction is turned off. Existing code that callsadd_dft_fluxto create a flux region for subsequent passage toget_eigenmode_coefficientsshould now calladd_mode_monitorinstead.