Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
6c34213
commit ab142ae
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab142ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's github... and we can just review the commit diff :)
ab142ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naturally. 😉
ab142ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd have to rebase the commit that first put the email in the Readme, then re-add the original readme, but without the email address. That should stop it from showing up in the commit diff, as git would think it was never there in the first place.
Rewriting git history is always a good learning opportunity!
https://help.github.com/articles/interactive-rebase
ab142ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I know how all about interactive rebasing and how to remove things from history. In this case, I wasn't interested in rewriting the public history given that the email is already posted elsewhere. I was only aiming to not post it in the
README
. 😏