modify position to right #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnowsCount
reviewed
May 1, 2021
| @@ -1,5 +1,5 @@ | |||
| // 注意：live2d_path 参数应使用绝对路径 | |||
| const live2d_path = "https://cdn.jsdelivr.net/gh/stevenjoezhang/live2d-widget@latest/"; | |||
| const live2d_path = const live2d_path = "https://cdn.jsdelivr.net/gh/ZKQevin/live2d-widget/"; | |||
There was a problem hiding this comment.
const live2d_path 为什么要写两遍？
为什么要换成你的 URL？
Suggested change
| const live2d_path = const live2d_path = "https://cdn.jsdelivr.net/gh/ZKQevin/live2d-widget/"; | |
| const live2d_path = "https://cdn.jsdelivr.net/gh/stevenjoezhang/live2d-widget@latest/"; |
KnowsCount
suggested changes
May 1, 2021
|
好的，谢谢您哈，我不是很懂这个东西，望您见谅
…------------------ 原始邮件 ------------------
发件人: ***@***.***>;
发送时间: 2021年5月1日(星期六) 上午10:52
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [stevenjoezhang/live2d-widget] modify position to right (#74)
@KnowsCount requested changes on this pull request.
我没有看懂，为什么要提这样一个 PR？
const live2d_path = const live2d_path = "https://cdn.jsdelivr.net/gh/ZKQevin/live2d-widget/"; 这句有错误；并且，原来在左边蛮好的，你要调节可以自己弄，不需要提 PR 吧。
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.