Added restrict_sr flag to Subreddit.search()

[SecareLupus]

Subreddit.search() defaults to searching the entirety of reddit. By adding the restrict_sr flag, the search will be restricted to the relevant subreddit.

[SecareLupus]

So, after looking around the various calls that are supported, I can't actually find another way to search all of reddit. I think given the way the api seems to be structured, the api needs to support searching all of reddit or just the sub it's called on, or there won't be a way to search all of reddit.

I still think that the default should be searching just the sub, but I'm pretty sure we need to either to make another function that doesn't set the sr_restrict flag or use the optional parameter solution.

[stevenroose]

Good point, maybe we need a search method in the main class.

[stevenroose]

Thanks for the PR btw!

[SecareLupus]

If we make a more oop-accurate search method in the main class, it will still have to generate a subreddit in order to search. I think it's just a weird idiosyncracy of the API. If you'd like I'll throw together a patch that does this later tonight. Probably just search via the reddit.frontpage subreddit, since that's an easy globally accessible Subreddit object.

…

On Sun, Dec 25, 2016, 11:45 Steven Roose ***@***.***> wrote: Thanks for the PR btw! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADMAhOfie4LplunYLKTnIgVzW3md_BQ4ks5rLp2fgaJpZM4LVHQH> .

[stevenroose]

I'm on mobile, but I thought the subreddit in the search API call was optional, so it should be possible to have a global search call. Otherwise I'd say r/all. We might make a `reddit.all` getter.

…

On 25 Dec 2016 6:04 p.m., "Desmond" ***@***.***> wrote: If we make a more oop-accurate search method in the main class, it will still have to generate a subreddit in order to search. I think it's just a weird idiosyncracy of the API. If you'd like I'll throw together a patch that does this later tonight. Probably just search via the reddit.frontpage subreddit, since that's an easy globally accessible Subreddit object. On Sun, Dec 25, 2016, 11:45 Steven Roose ***@***.***> wrote: > Thanks for the PR btw! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/stevenroose/dart-reddit/pull/ 6#issuecomment-269129592>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ ADMAhOfie4LplunYLKTnIgVzW3md_BQ4ks5rLp2fgaJpZM4LVHQH> > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0F3FzUNaTTZGvIo8FELTEhDVJeN4drks5rLqIFgaJpZM4LVHQH> .