Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API is not supporting IE browsers #651

Closed
ngocthinh192 opened this issue Apr 14, 2020 · 10 comments
Closed

API is not supporting IE browsers #651

ngocthinh192 opened this issue Apr 14, 2020 · 10 comments
Labels
bug v2 Related to the Version 2 release

Comments

@ngocthinh192
Copy link

Thanks so much for your API.
That was a huge upgrade. But I realize the API is not supporting IE browsers. Including IE 11, IE 10, IE 9, ...

@benjamin-hull
Copy link
Collaborator

benjamin-hull commented Apr 14, 2020

Hi @ngocthinh192 - and thanks!

What specifically about v2 is not working for you in those browsers?

The v2 code is written with older IE's in mind, though we definitely need to do more testing. We'll also need to publish the list of supported browsers - I'm not sure if IE9 will be supported, but I think 10 & 11 will be (TBC).

@benjamin-hull benjamin-hull added the v2 Related to the Version 2 release label Apr 14, 2020
@ngocthinh192
Copy link
Author

ngocthinh192 commented Apr 14, 2020 via email

@benjamin-hull
Copy link
Collaborator

benjamin-hull commented Apr 14, 2020

Hi again - I can't see your image attachments (I don't think they work when you reply-via-email).

That said, I think it's Codepen.io that doesn't work with IE, not Instafeed, so you won't be able to test Instafeed that way with those browsers. You would need to set up your own install locally to test them.

@ngocthinh192
Copy link
Author

I so sorry about the image error.
I understand that Codepen.io does not work in IE.
I have set it up on my website and tested it.
I only use your AccessToken for my testing.

IE 11 :
IE11

IE10 :
IE10

IE9:
IE9

Thank you so much !

@benjamin-hull
Copy link
Collaborator

Alright - looks like we have some mores testing to do. Thanks for raising this.

@stevenschobert
Copy link
Owner

Hey @ngocthinh192, can you try using the non-minified source and let me know what you see?

@ngocthinh192
Copy link
Author

Hi stevenschobert !
This is a screenshot when I using the non-minified source.

IE_11_01

IE_11_02

@stevenschobert
Copy link
Owner

Cool, thanks for the report @ngocthinh192! We'll take a look and get back to you!

@ngocthinh192
Copy link
Author

Oh thank you so much and thank you for your great API.
@stevenschobert

@stevenschobert
Copy link
Owner

Hey everyone! This has been fixed in v2.0.0-rc2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug v2 Related to the Version 2 release
Projects
None yet
Development

No branches or pull requests

3 participants