-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve examples #28
Improve examples #28
Conversation
Also update types to allow not just zod objects as schemas
🦋 Changeset detectedLatest commit: 31fc4ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very cool! I reckon we could probably document each example a little bit more down the road but this is a great addition for now!
Maybe my only feedback is that we could have a more involved third party field example. The currency one is a good pragmatic use case but its not super obvious how its different at a first glance.
LGTM
Yeah, I wanna actually bring in some component libraries that need this, but I started thinking that it might be better as a codesandbox anyway, so I'm going to merge this in first while I think about it |
Closes #25