Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples #28

Merged
merged 12 commits into from
Aug 9, 2023
Merged

Improve examples #28

merged 12 commits into from
Aug 9, 2023

Conversation

GRA0007
Copy link
Member

@GRA0007 GRA0007 commented Jul 14, 2023

Closes #25

  • Kitchen sink (App.tsx)
  • Basic example
  • Array field
  • Nested fields
  • Coerced fields
  • Conditional field
  • 3rd party and controlled fields

@GRA0007 GRA0007 self-assigned this Jul 14, 2023
@GRA0007 GRA0007 mentioned this pull request Jul 14, 2023
16 tasks
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 31fc4ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stevent-team/react-zoom-form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GRA0007 GRA0007 marked this pull request as ready for review August 8, 2023 08:42
@GRA0007 GRA0007 requested a review from giraugh August 8, 2023 08:42
Copy link
Member

@giraugh giraugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very cool! I reckon we could probably document each example a little bit more down the road but this is a great addition for now!

Maybe my only feedback is that we could have a more involved third party field example. The currency one is a good pragmatic use case but its not super obvious how its different at a first glance.

LGTM

@GRA0007
Copy link
Member Author

GRA0007 commented Aug 9, 2023

Yeah, I wanna actually bring in some component libraries that need this, but I started thinking that it might be better as a codesandbox anyway, so I'm going to merge this in first while I think about it

@GRA0007 GRA0007 merged commit ed27e64 into main Aug 9, 2023
3 checks passed
@GRA0007 GRA0007 deleted the docs/improve-examples branch August 9, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation
2 participants