Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary rerenders and nullable controlled values #38

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

GRA0007
Copy link
Member

@GRA0007 GRA0007 commented Aug 10, 2023

This PR attempts to reduce the amount of rerenders that happen when filling out a form by switching to a ref inside the field chain.

It also fixes a bug where a controlled field with a nullable value would not correctly set the types as nullable.

@GRA0007 GRA0007 requested a review from giraugh August 10, 2023 05:47
@GRA0007 GRA0007 self-assigned this Aug 10, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

🦋 Changeset detected

Latest commit: b9a77a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stevent-team/react-zoom-form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@giraugh giraugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Making slow iterative progress B)

lib/field.ts Show resolved Hide resolved
@GRA0007 GRA0007 merged commit 384a1b0 into main Aug 10, 2023
4 checks passed
@GRA0007 GRA0007 deleted the fix/rerenders-and-nullable-controlled branch August 10, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants