-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: Cannot assign to read only property 'response' of object '[object Object]' #184
Comments
I got this error as well! |
so, i have the same situation |
I have the same problem |
I also have this error |
I debugged this a little bit and on my end it looks like it breaks once it tries to check link which is behind a VPN. In this case it doesn't receive any response (I believe) and fails in a not graceful way. My workaround is to exclude the hostname in |
It's not a vpn issue for me. One example of where it crashes is when it tries analyzing the following url "blc https://www.ucc.edu/admissions/federal-aid-programs/ -ro" |
got the same issue |
Same here. It looks like it's all links behind our proxy only urls going through our http(s)_proxy. |
I guess it could be handled in a more graceful way, e.x. flag the link as broken with a |
I'm not really sure if the link is broken. When checking the links where this occurs manually, they do seem to work (even with a curl from the same server). I do agree that just printing an error and exiting isn't the right way of doing this. |
I have the same problem, but only when |
im having the same problem and none of these answers are helping me |
In the first post, I added a really bad workaround, that at least worked for me: Manually go to the last page checked prior to the error, and test each link on that page in your browser. Then remove any links from the page that timeout, for example, links that go to domains that no longer exist. Then rescan & repeat. Of course, this won't be feasible for links that do work but are behind a proxy or accessible via a VPN, etc. But perhaps it will help somebody. |
I'm having the same problem, but it seems that this originates actually from a problem with the timeout handling of bhttp. |
I've got another type error here #196 . |
I've got the same behavior here. I've tried kmanuel's suggestion and it worked. |
Guys, I just noticed that the new version of blc does not uses the bhttp module anymore, maybe it's time to use the new blc version. |
@kmanuel can you please suggest how to use bhttp with blc? I’m facing same issue. If you can share an example that would be very helpful |
@thiagosanches Which new version? Latest one is |
Hi @gauravgandhi1315 , Not sure if |
@thiagosanches how did you make it work on your machine? Can you share your fix? |
@thiagosanches Can you please share how did you see bhttp with blc version 0.7.8? You mentioned in one of your comment that problem solved for you. #184 (comment) |
I've promised myself to finish v0.8 this fall. It's summer, so I'm doing other things. Try: npm install github:stevenvachon/broken-link-checker && cd node_modules/broken-link-checker && npm run build && ./bin/blc |
The API is different for v0.8 |
@stevenvachon I am still using 0.7.8. So this error will be there for blc 0.7.8? There is no fix for it? |
So much has changed from 0.7.8 and bhttp was a problem for a long time. I'm not sure what is causing your issue. |
@stevenvachon I get this error only within vpn network. Without vpn, it works fine. |
bhttp doesn't support proxies. |
@stevenvachon Ok, so blc will not work within vpn network. Is there any work around to fix this issue? |
@stevenvachon This library works very well except this issue |
It's been a while, but I think v0.8 (master branch) supports proxies. I remember not figuring out how to automate testing them, though. |
Hey @gauravgandhi15, sorry for the delay. The mentioned workaround was to change the bhttp module version. You can try to update on your own package.json and force it to use the 1.1.0 version of that module. |
@thiagosanches I am not using bhttp. Just using blc 0.7.8 |
@thiagosanches Can you give an example on how to use bhttp with blc? |
@gauravgandhi15, So, for example, on my side I've changed it to use the 1.1.0 version of the bhttp module: |
@thiagosanches after installing blc, it did not install bhttp for me. I tried adding in my package.json. Still seeing same error |
This seems to fix the problem. Now bhttp properly throws the timeout error and blc lists link as broken and does not stop there ConnectionTimeoutError: The connection timed out. |
@jukkapirinen this solved my issue, thanks! |
@stevenvachon Any updates on newer version? When are you planning to release it? |
ge
|
Yep, this was caused by a bug in bhttp. I hadn't gotten around to reviewing the PR that fixes it until today. Sorry! I just released a new version of bhttp, (That having been said, it seems that the upcoming releases uses |
Describe the bug
During a recursive ordered broken link check, blc starts checking and successfully finding broken links, then part of the way through, it hangs, and eventually dumps out a TypeError:
To Reproduce
npm install -g broken-link-checker
blc https://example.com -ro
Expected behavior
A completed broken link scan.
Environment:
Possible (terrible) workaround:
Manually go to the last page checked prior to the error, and test each link on that page in your browser. Then remove any links from the page that timeout, for example, links that go to domains that no longer exist.
The text was updated successfully, but these errors were encountered: