Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiteChecker.prototype.on is not a function #253

Open
hasezoey opened this issue Feb 5, 2023 · 0 comments
Open

SiteChecker.prototype.on is not a function #253

hasezoey opened this issue Feb 5, 2023 · 0 comments

Comments

@hasezoey
Copy link

hasezoey commented Feb 5, 2023

Describe the bug
SiteChecker.prototype.on is not a function

To Reproduce

const { SiteChecker } = require('broken-link-checker');
const { EventEmitter } = require('events');

const siteChecker = new SiteChecker({});

console.log(siteChecker instanceof EventEmitter); // logs: false

siteChecker.on('end', () => {}); // Error, ".on" is not a function

Expected behavior
to correctly inherit EventEmitter, or at least provide the mentioned functions

from the documentation:

All methods from EventEmitter are available.

Environment:

  • OS and version: Manjaro 22.0.1
  • Node.js version: 19.5.0
  • broken-link-checker version: 0.7.8

It seems like this issue would be solved if 0.8.0 would be released, as requested in #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant