Handle invalid X-Robots-Tag header values #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevenvachon Could this PR be merged? |
|
@Mickael-van-der-Beek please rebase |
|
@stevenvachon Done. Sorry for the delay. |
|
@Mickael-van-der-Beek the coverage dropped |
|
This has been implemented on master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the
X-Robots-Tagheader value is invalid, the regular expression will returnnullwhich will break the line after when it is assumed thatresultis an array and an element is accessed by index.This fix will make the code fallback to the default value of
result.Example of a failing case (found in the wild):
'noindex, nofollow\nnosnippet, noarchive'