Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No vertical scrolling possible #1235

Open
kvonspiczak opened this issue Feb 12, 2019 · 8 comments
Open

No vertical scrolling possible #1235

kvonspiczak opened this issue Feb 12, 2019 · 8 comments

Comments

@kvonspiczak
Copy link

i think i've found a regression. i just tried upgrading from 4.2.12 to 4.2.15 but the bug is still present.

see: #82 & #616

i cant scroll past the slider on a mobile device since it considers my scrolling as a "slide" event.

@Masner
Copy link

Masner commented Feb 20, 2019

Bug is caused by preventDefault in onTouchStart function. I dont know, why is it there, so take it only as a hint.

@kvonspiczak
Copy link
Author

kvonspiczak commented Feb 20, 2019

@Masner yes you're right. i fixed it by patching the bxslider.js file in our project with the following changes:
image
image
image

using version 4.2.15 (4.2.1d)

@robertripoll
Copy link

@Masner yes you're right. i fixed it by patching the bxslider.js file in our project with the following changes:
image
image
image

using version 4.2.15 (4.2.1d)

Thank you! That did the trick.

gmenoiaa added a commit to gmenoiaa/bxslider-4 that referenced this issue Feb 28, 2019
@giudansky
Copy link

lost days finding this solution.
So we can't use any cdn right? No official fixes or branch with this mod?

Thanks

@vorlox
Copy link

vorlox commented Jun 20, 2019

Thanks for the fix! You saved my day.

@jhume
Copy link

jhume commented Nov 24, 2020

Same issue here. Would be good to have an official fix for this rather than having to hack the codebase.

@Golden-Puma
Copy link

Golden-Puma commented May 11, 2021

Спасибо @kvonspiczak

@giudansky
Copy link

any reason this fix was not submitted to the final ver ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants