Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow nested childrens for slideSelector #653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gajdy
Copy link

@gajdy gajdy commented Oct 13, 2014

This commit allows to set slideSelector as nested children of bx container. I'm using .page as slideSelector for big resolutions and .slide for smaller

<section class="bx-wrapper">
<div class="page">
<div class="slide">content</div>
<div class="slide">content</div>
<div class="slide">content</div>
</div>
<div class="page">
<div class="slide">content</div>
<div class="slide">content</div>
<div class="slide">content</div>
</div>
</section>

@RyanONeill1970
Copy link

Would agree this is a very useful patch, the older versions of bxSlider used to do this and upgrading broke due to our sliders using sub elements.

@machwatt
Copy link

Any updates on that? Since children() only traverse a single DOM level, this could be very helpful.
Or is there another way to implement the behaviour as described above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants