Fix compatibility with Sphinx 4 and 5.0b1. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemac
commented
May 17, 2022
| @@ -88,7 +88,7 @@ def keyfunc(entry): | |||
| self.add_line(u'', '<autointerface>') | |||
| self.indent += self.content_indent | |||
| sourcename = u'docstring of %s.%s' % (self.fullname, name) | |||
| docstrings = [prepare_docstring(doc, None)] | |||
There was a problem hiding this comment.
This is needed for version 5.0b1
stevepiercy
approved these changes
May 17, 2022
|
@icemac thank you! I also have no idea if it is the right thing, but as long as tests pass, I'm happy. |
|
Test environments are out of date and cause failures. We should drop those that are now EOL, including 3.6. |
|
Hi @stevepiercy I updated the GHA config, so it should be able to run through. |
|
All green! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stevepiercy, this PR adds up on the changes you made to
repoze.sphinx.autointerface. Locally the tests run with Sphinx 4, 4.5 and 5.0b1.Spoiler: I am not sure if it is right what I did, I just made the things necessary to get the tests running again.
Could you please consider this PR to make some progress for this package.