Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh build env #48

Merged
merged 7 commits into from
Feb 26, 2018
Merged

refresh build env #48

merged 7 commits into from
Feb 26, 2018

Conversation

stevermeister
Copy link
Owner

@stevermeister stevermeister commented Feb 22, 2018

@bampakoa I've fixed playground, please have a look.
but broke test env :(

Plus: fixed focus issue - #47

@bampakoa
Copy link
Collaborator

@stevermeister ignore my previous comment. I am checking your PR right now and I will come back to you. By the way, it this the same playground?

tsconfig.json Outdated
"node"
]
"typeRoots": ["node_modules/@types"],
"types": ["jasmine", "node"]
Copy link
Collaborator

@bampakoa bampakoa Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"paths": {
      "ngx-wig": [
        "../dist/ngx-wig"
      ]
    }

otherwise tsc command fails

@bampakoa
Copy link
Collaborator

In ./playground/tsconfig.json add

"baseUrl": ".",
"paths": {
      "ngx-wig": [
        "../dist/ngx-wig"
      ]
}

otherwise, the IDE throws an error

In karma.conf.js append "exclude": ["./playground"] in the karmaTypescriptConfig for the tests to pass

@stevermeister
Copy link
Owner Author

@bampakoa sorry, did not get your point about tsconfig.json, could I ask you to make separate PR fix for it?

@stevermeister stevermeister merged commit 51b88e7 into master Feb 26, 2018
@stevermeister stevermeister deleted the sandbox branch February 26, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants