Skip to content

Commit

Permalink
Fix integration TestSingleBinaryWithMemberlistScaling flaking.
Browse files Browse the repository at this point in the history
This appears to be highlighting an issue - raised as cortexproject#4360.
This change just stops the test flaking until it can be fixed.

Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
  • Loading branch information
stevesg committed Jul 12, 2021
1 parent 733f7de commit 2637a95
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions integration/integration_memberlist_single_binary_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,13 @@ func TestSingleBinaryWithMemberlistScaling(t *testing.T) {
c := instances[i]
instances = instances[:i]
stop.Go(func() error { return s.Stop(c) })

// TODO(#4360): Remove this when issue is resolved.
// Wait until memberlist for all nodes has recognised the instance left.
// This means that we will not gossip tombstones to leaving nodes.
for _, c := range instances {
require.NoError(t, c.WaitSumMetrics(e2e.Equals(float64(len(instances))), "memberlist_client_cluster_members_count"))
}
}
require.NoError(t, stop.Wait())

Expand Down

0 comments on commit 2637a95

Please sign in to comment.