Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update table component to support borderless and sizing props #109

Merged
merged 4 commits into from
Nov 6, 2018

Conversation

stevesims
Copy link
Owner

It's now possible to set a borderless flag on the Table component to make the borders vanish.

Additionally the vertical sizing of cells (padding) can be set by specifying a sizing prop. By default this uses the value of SPACING.SCALE_3 from @govuk-react/constants

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     27           
  Lines         215    218    +3     
  Branches       46     46           
=====================================
+ Hits          215    218    +3
Impacted Files Coverage Δ
components/table/src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a29c0...1665b84. Read the comment docs.

@gavinorland gavinorland self-requested a review November 6, 2018 17:32
Copy link
Collaborator

@gavinorland gavinorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can work on the skipped test, as discussed :)

@stevesims stevesims merged commit a5da1e8 into master Nov 6, 2018
@stevesims stevesims deleted the feature/table-tweaks branch November 6, 2018 17:37
@gavinorland
Copy link
Collaborator

I found out a bit more about this: if either the first-child or the last-child blocks are present, then the first style property outside them is set but cannot be found, regardless of what it is and of whether those blocks are placed before of after the other rules. So, for example, if we move borderBottom to after display then it's found, but display isn't!

@stevesims stevesims mentioned this pull request Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants