Remove Swagger integration #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The Swagger / OpenAPI spec is no longer exposed by default * Applications wishing to expose their OpenAPI spec can do so on their own, see https://github.com/swagger-api/swagger-core/wiki/Swagger-2.X---Integration-and-Configuration#exposing-openapi-definition * Resources provided by Alpine now use `swagger-annotations` in version `2.x` Signed-off-by: nscuro <nscuro@protonmail.com>
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Swagger integration in Alpine.
swagger-annotationsin version2.xCloses #1
@stevespringett This is in line with my proposal in #402 (comment).
I took another mid-term solution regarding the OpenAPI v3 migration though:
Reason being that this work is blocking the Jakarta migration (#402), and moving to manually maintained OpenAPI manifests is a lot of continuous work. This solution unblocks us, but we can still move to manually maintained manifests later on.
There will be no work necessary in Alpine, since this PR already rips out its native Swagger integration.