checkIsRepo() always return true

[mittalyashu]

Every time I try to run this code with git and non-git repository, it always returns true.

validateGit(path) {
			let validateGitRepo = git(path);
			validateGitRepo.checkIsRepo()
			.then(result => {
				console.log(result);
			}).catch(error => {
				console.log(error);
			});
		}

Answer: #345 (comment)

[steveukx]

There's now an integration test to show how the checkIsRepo interface is expected to work... the standard git binary will return true for any directory under a valid git root, which is what this library bases its response on.

Please can you add an integration test based on test-check-is-repo that shows how the result variable doesn't match true for a root / folder within a root, or false for any other directory.

[mittalyashu]

the standard git binary will return true for any directory under a valid git root

I get that, but it was returning true even if git is not initialized inside the repository.

[mittalyashu]

This code is exactly the same as you have written in the tests.

[mittalyashu]

Hey @steveukx, did you got the chance to read the above comments?

[mittalyashu]

the standard git binary will return true for any directory under a valid git root

What does it mean that it will always return true?

[mittalyashu]

Found the cause of the problem, turns out that somehow I must have initialized a git repository in my C:// drive, which was causing the issue.