DiffSummary strips trailing spaces in file names

[yuribro]

If there's a file with trailing spaces in its name, DiffSummary returns the file name with the trailing space trimmed.
To reproduce:

echo text > 'a '
git add .

The output of diffSumary:

> await git.diffSummary(['--cached'])
DiffSummary {
  changed: 1,
  deletions: 0,
  insertions: 1,
  files: [
    {
      file: 'a',
      changes: 1,
      insertions: 1,
      deletions: 0,
      binary: false
    }
  ]
}

But calling diff you can see the extra space (on the +++ line, there's a space before \t)

> await git.diff(['--cached'])
'diff --git a/a  b/a \n' +
  'new file mode 100644\n' +
  'index 0000000..8e27be7\n' +
  '--- /dev/null\n' +
  '+++ b/a \t\n' +
  '@@ -0,0 +1 @@\n' +
  '+text\n'

[EllaSharakanski]

@steveukx Looks like maybe removing the trim() call here should do the trick

git-js/simple-git/src/lib/parsers/parse-diff-summary.ts

Line 58 in c022042

file: line[1].trim(),

[steveukx]

@EllaSharakanski the output for diff --stat=4096 pads file names so they appear the same length in the output, so the trim() that removes those can't tell the difference between padding and a file with a trailing space in its name.

I am working on a change to the library to merge the output of both diff --stat and diff --numstat to reliably detect the file names (as supplied by diff --numstat) while still retrieving the file size of binary file changes (only available in diff --stat).

@yuribro thank you for opening the detailed issue - I will update here once a resolution is available.

[steveukx]

Hello again. Apologies for the delay in getting back to this one - a new version of simple-git will be published this weekend that will enable you to use git.diffSummary(['--name-stat']) to cater for the files with trailing spaces in their file names.