Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git log: using only one of "from", "to" #845

Closed
bieron opened this issue Aug 22, 2022 · 2 comments · Fixed by #846
Closed

git log: using only one of "from", "to" #845

bieron opened this issue Aug 22, 2022 · 2 comments · Fixed by #846

Comments

@bieron
Copy link

bieron commented Aug 22, 2022

if (opt.from && opt.to) {

Hi there, big fan of this repo.
Is there any particular reason why LogOptions from and to are only applied when both present? Is this a safety measure against something? It denies a valid use case of git log someCommit.. or git log ..someCommit (basically, allowing git to assume HEAD)

steveukx added a commit that referenced this issue Aug 22, 2022
* Allow using just one of `from` and `to` in the `git.log` options.

Closes #845
@steveukx
Copy link
Owner

Hi, there's no great reason to force using both - you can now use simple-git@3.13.0 with one or other of from and to

@bieron
Copy link
Author

bieron commented Aug 22, 2022

Wow, that was quick, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants