Make initialization thread-safe, and support early callers #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current initialization code is not thread-safe, and assumes that the only possible caller of open() before initialization completes is dlsym(), which is not the case if there are other preloaded libraries. This patch makes the initialization thread-safe by using thread-local variables, and adjusts the recursive checking logic to support early callers. Bug-Debian: https://bugs.debian.org/918520 Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>
|
Note though that this requires c11 for |
|
Well, that's interesting! Merged in at 9159bc1 and in v129. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current initialization code is not thread-safe, and assumes that the
only possible caller of open() before initialization completes is
dlsym(), which is not the case if there are other preloaded libraries.
This patch makes the initialization thread-safe by using thread-local
variables, and adjusts the recursive checking logic to support early
callers.
See Debian bug #918520 for more background: https://bugs.debian.org/918520
Signed-off-by: Mattia Rizzolo mattia@debian.org