Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix result dictionary #136

Merged
merged 6 commits into from
Jun 5, 2024
Merged

fix result dictionary #136

merged 6 commits into from
Jun 5, 2024

Conversation

federicazanca
Copy link
Collaborator

close #135

@federicazanca federicazanca added bug Something isn't working aiida-mlip to help filter the issues labels Jun 3, 2024
@federicazanca federicazanca self-assigned this Jun 3, 2024
@ElliottKasoar
Copy link
Member

The test errors may well be related to ASE 3.23.0

ElliottKasoar
ElliottKasoar reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to add a test that would fail before this change.

@federicazanca
Copy link
Collaborator Author

federicazanca commented Jun 3, 2024 •
edited
Loading

It might be nice to add a test that would fail before this change.

Yeah I'm trying to do this, I think actually maybe the failing test is because of this change (maybe)

@federicazanca
Copy link
Collaborator Author

The test errors may well be related to ASE 3.23.0

On second thought this is probably the cause of all the problems

@ElliottKasoar ElliottKasoar mentioned this pull request Jun 4, 2024
Closed
ElliottKasoar
ElliottKasoar approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is doing a couple of different things at the same time, but nothing too extreme. We should double check the docs match the stricter output file

@ElliottKasoar ElliottKasoar merged commit 3c4d7ec into stfc:main Jun 5, 2024
8 checks passed
@federicazanca federicazanca deleted the 135-fix-results-dictionary branch June 21, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElliottKasoar ElliottKasoar ElliottKasoar approved these changes

@alinelena alinelena Awaiting requested review from alinelena

Assignees

@federicazanca federicazanca

Labels
aiida-mlip to help filter the issues bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix results dictionary
3 participants
@federicazanca @ElliottKasoar @alinelena