Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pypi badge #11

Merged
merged 5 commits into from
Feb 8, 2017
Merged

Pypi badge #11

merged 5 commits into from
Feb 8, 2017

Conversation

rupertford
Copy link
Collaborator

Added a pypi version badge and a python supported versions badge to the README. This uses shields.io badges. The idea was cribbed from James' longbow repository.

Test to see if we can create a pypi version badge in our readme.
try to see if we can add a python supported versions badge to the readme
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.617% when pulling b3db9d0 on pypi-badge into ae6fb54 on master.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks OK but the badges are still not actually working for me. Therefore I cannot approve at this point. Do they work for you?

Trying png rather than svg
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.617% when pulling 6819b31 on pypi-badge into ae6fb54 on master.

Trying jpg to see if this works
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.617% when pulling 04a85d7 on pypi-badge into ae6fb54 on master.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not seen this working but Rupert assures me that he has so I will approve.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.617% when pulling 7ba8b2a on pypi-badge into ae6fb54 on master.

@rupertford rupertford merged commit 4d57ba5 into master Feb 8, 2017
@rupertford rupertford deleted the pypi-badge branch February 8, 2017 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants