Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow strings for optimization function names #179

Merged
merged 12 commits into from
Jun 4, 2024

Conversation

ElliottKasoar
Copy link
Member

No description provided.

@ElliottKasoar ElliottKasoar added enhancement New feature or request janus labels Jun 3, 2024
@ElliottKasoar ElliottKasoar self-assigned this Jun 3, 2024
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@oerc0122 oerc0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Just a couple of minor questions.

janus_core/calculations/geom_opt.py Outdated Show resolved Hide resolved
janus_core/calculations/geom_opt.py Outdated Show resolved Hide resolved
janus_core/calculations/geom_opt.py Outdated Show resolved Hide resolved
janus_core/cli/geomopt.py Show resolved Hide resolved
janus_core/cli/geomopt.py Show resolved Hide resolved
janus_core/cli/geomopt.py Outdated Show resolved Hide resolved
janus_core/cli/geomopt.py Show resolved Hide resolved
@ElliottKasoar ElliottKasoar mentioned this pull request Jun 3, 2024
@ElliottKasoar ElliottKasoar mentioned this pull request Jun 4, 2024
@ElliottKasoar ElliottKasoar merged commit 674ab6b into stfc:main Jun 4, 2024
8 checks passed
@ElliottKasoar ElliottKasoar deleted the add-geomopt-functions branch June 4, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request janus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants