This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Provide download functionality for documents #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgarf
reviewed
Mar 16, 2020
There was a problem hiding this comment.
Hey @Zibby, I appreciate your contribution to the project!
I have a few comments in the code but from what I checked out and tested it seems to work well so far. Go ahead and address those issues and we can get it merged in.
git rm paperless-cliRemove the binary, we don't need to check it into git.- Edit the
VERSIONfile and bump the minor version, I guess we're at0.7.0now. - Please go ahead and update
README.mdand add yourself to the authors/acknowledgements section.
stgarf
suggested changes
Mar 16, 2020
stgarf
reviewed
Mar 16, 2020
stgarf
suggested changes
Mar 16, 2020
|
Oh hey @Zibby, I also just recently updated the go modules version dependencies, so make sure to |
Addressing: stgarf#7 Uses existing function to find a list of matching filenames, if only one entry matches, downloads it to current dir, if there are multiple matches provide an indexed list to select from
|
Closes #7. |
This was referenced Apr 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses existing function to find a list of matching filenames, if only one
entry matches, downloads it to current dir, if there are multiple
matches provide an indexed list to select from
Motivation and Context
Addressing: #7
How Has This Been Tested?
Local testing against my selfhosted paperless server, using multiple file paths
Screenshots (if appropriate):
N/A
Types of changes
Checklist: