Sync Fork from Upstream Repo #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use the bare "C" locale, which makes character handling outside of the ASCII range not work as expected. Switch to "C.utf8" (but keep bare "C" for collation). This also spells locale and encoding explicitly for newly created databases. Not all systems support C.UTF-8, so fallback to en_US.UTF-8 in those cases. Fixes: #1105.
Per PEP 538, Python's `locale.getlocale()` will return `'en_US.UTF-8'` if the system's locale is set to `"C"`, and so a subsequent `locale.setlocale()` call will fail. So, instead of doing save/restore, do it the `setlocale` way and revert to the global default by passing an empty string.
This is almost identical to the nightly build (without the "nightly" part obviously).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.