Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --component (-c) to create a root comopnent #2

Closed
3 tasks done
sthzg opened this issue Jul 9, 2016 · 0 comments
Closed
3 tasks done

Support --component (-c) to create a root comopnent #2

sthzg opened this issue Jul 9, 2016 · 0 comments
Assignees
@sthzg

Comments

@sthzg
Copy link
Owner

sthzg commented Jul 9, 2016 •
edited
Loading 

react-webpack:container foo --component
# Creates Foo.js and FooContainer.js. FooContainer.js renders <Foo/>

react-webpack:container foo --component bar
# Creates Bar.js and FooContainer.js. FooContainer.js renders <Bar/>

Todos

  • Create container and component files
  • Make container import and render component
  • Modify generated test for container component
@sthzg sthzg self-assigned this Jul 9, 2016
@sthzg sthzg changed the title Support --component (-c) option to create a root comopnent Support --component (-c) to create a root comopnent Jul 9, 2016
sthzg added a commit that referenced this issue Jul 10, 2016
@sthzg
[WIP] Added gulp command to transform file from hostgen #2
58aca26 
Initial commit adding basic functionality. If container is invoked with
the --component flag, a transformation edits the generated source to
import the root component (not created yet).
sthzg added a commit that referenced this issue Jul 18, 2016
@sthzg
[WIP] Added AST transformation on container component #2
022c692
sthzg added a commit that referenced this issue Jul 18, 2016
@sthzg
Added support for --component option #2
d4be526
@sthzg sthzg mentioned this issue Jul 18, 2016
Merged
@sthzg sthzg closed this as completed in #3 Jul 18, 2016
sthzg added a commit that referenced this issue Jul 18, 2016
@sthzg
Added support for --component option (#3)
3ae507f 
Running `yo react-webpack:container foo --component` will create `<Foo />` and `<FooContainer />` and modifies `<FooContainer />`'s render method to render `<Foo />`.

Closes #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sthzg sthzg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sthzg