Skip to content

Commit

Permalink
Hostgen validation is done before populating it. This is now one sing…
Browse files Browse the repository at this point in the history
…le task.
  • Loading branch information
stylesuxx committed Jul 8, 2016
1 parent 2a773e0 commit 9e808b7
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 14 deletions.
3 changes: 0 additions & 3 deletions generators/activate/index.js
Expand Up @@ -28,9 +28,6 @@ class Generator extends generators.Base {
cacheInstalledPackages() {
tasks.cacheInstalledPackages(this);
},
validateHostgenExists() {
tasks.validateHostgenExists(this);
},
populateHostgenPkg() {
tasks.populateHostgenPkg(this);
}
Expand Down
3 changes: 0 additions & 3 deletions generators/deactivate/index.js
Expand Up @@ -29,9 +29,6 @@ class Generator extends generators.Base {
cacheInstalledPackages() {
tasks.cacheInstalledPackages(this);
},
validateHostgenExists() {
tasks.validateHostgenExists(this);
},
populateHostgenPkg() {
tasks.populateHostgenPkg(this);
}
Expand Down
3 changes: 0 additions & 3 deletions generators/scan/index.js
Expand Up @@ -26,9 +26,6 @@ class Generator extends generators.Base {
cacheInstalledPackages() {
tasks.cacheInstalledPackages(this);
},
validateHostgenExists() {
tasks.validateHostgenExists(this);
},
populateHostgenPkg() {
tasks.populateHostgenPkg(this);
}
Expand Down
6 changes: 1 addition & 5 deletions utils/tasks.js
Expand Up @@ -157,12 +157,8 @@ function validateHostgenExists(generator) {
* @param generator
*/
function populateHostgenPkg(generator) {
validateHostgenExists(generator);
const pkgQ = utils.getPkgInfo(generator.hostFullName, generator.pkgList);

if (pkgQ.hasError) {
generator.env.error(`Couldn't get package info for ${generator.hostFullName} .`);
}

generator.hostPkg = pkgQ.data.get('pkg');
}

Expand Down

0 comments on commit 9e808b7

Please sign in to comment.