Added more unit tests for getPkgInfo #11

Fixed bug for returning an error along the way
sthzg · Jul 8, 2016 · c70accf · c70accf
1 parent 7ae5dff
commit c70accf
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/test/utils/utilsTest.js b/test/utils/utilsTest.js
@@ -63,11 +63,21 @@ describe('getPkgInfo()', () => {
     });
 
     it('returns data from package.json', function () {
-      const pkg = utils.getPkgInfo('sp1dir1', this.store);
-      chai.equal(pkg.hasError, false);
-      chai.equal(pkg.pkg.version, '1.0.0');
-      chai.equal(pkg.pkg.name, 'sp1dir1pkg');
-      chai.equal(pkg.pkg.path, '/tmp/searchPath1/sp1dir1');
+      const pkgQ = utils.getPkgInfo('sp1dir1', this.store);
+      chai.equal(pkgQ.hasError, false);
+      chai.equal(pkgQ.pkg.version, '1.0.0');
+      chai.equal(pkgQ.pkg.name, 'sp1dir1pkg');
+      chai.equal(pkgQ.pkg.path, '/tmp/searchPath1/sp1dir1');
+    });
+
+    it('returns data for a matching substring with exact=fasle', function () {
+      const pkgQ = utils.getPkgInfo('sp1', this.store, false);
+      chai.equal(pkgQ.pkg.name, 'sp1dir1pkg');
+    });
+
+    it(`returns an error if pkg can't be found`, function () {
+      const pkgQ = utils.getPkgInfo('xyz', this.store);
+      chai.equal(pkgQ.hasError, true);
     });
 
     after(function () {

diff --git a/utils/utils.js b/utils/utils.js
@@ -88,9 +88,10 @@ function getPkgInfo(pkgName, installed, exact=true) {
     });
 
     return buildSuccess({ pkg: pkg });
-  }
 
-  return buildError(`${pkgName} not found in installed packages.`);
+  } else {
+    return buildError(`${pkgName} not found in installed packages.`);
+  }
 }