Initial implementation of Noordhoff client/server #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation of Noordhoff client/server
hhaarsma
requested review from
cliftonc,
dpronk,
EvanderVeen,
HJTLN,
mcginkel,
mzetstra,
niesink and
wvholland
as code owners
cliftonc
approved these changes
Mar 8, 2021
|
I hope you don’t expect me to do a review of this massive PR / Merge into Master before 13:00 today ….
Kind regards
Danny
… Op 8 mrt. 2021, om 09:44 heeft hhaarsma ***@***.***> het volgende geschreven:
@hhaarsma <https://github.com/hhaarsma> requested your review on: #53 <#53> Initial implementation of Noordhoff client/server as a code owner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH46FZBXINTMKERMMCGVKTTCSFAXANCNFSM4YY7GSCQ>.
|
|
No, not at all - it's us open sourcing our implementation - so no need for review. |
|
Can we move this to another folder? Why is this suddenly the "implementation"? |
|
Well, it is the implementation of the LA services in the prototype? This isn't 'THE' implementation (if there is such a thing outside of each participant anyway). Edit - sorry just realised that it isn't in an 'LA' folder - I'll ask @hhaarsma to move. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of Noordhoff client/server