Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callbacks aren't called after initializing a new instance without callbacks #13

Closed
stidges opened this issue Nov 25, 2016 · 1 comment
Closed

Callbacks aren't called after initializing a new instance without callbacks #13

stidges opened this issue Nov 25, 2016 · 1 comment

Comments

@stidges
Copy link
Owner

stidges commented Nov 25, 2016

Because the searchActiveCallback, searchEmptyCallback, searchBlurCallback and searchFocusCallback are global variables, different instances of the plugin will interfere.

For example, if a plugin instance gets initialized with a onSearchEmpty callback and another instance gets initialized after that without a onSearchEmpty callback, it will not be called for the first instance anymore.

This can be solved by moving the variables into the plugin instance.
stidges added a commit that referenced this issue Nov 25, 2016
@stidges
Make sure plugin instance callbacks don't interfere (closes #13)
152b682
@stidges
Copy link
Owner Author

stidges commented Nov 25, 2016

Fix will be available in v2.0.0

@stidges stidges closed this as completed Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stidges