Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added an optional NSComparator to be used when sorting the output JSON. #122

Merged
merged 5 commits into from Feb 16, 2012

Conversation

Projects
None yet
2 participants
Contributor

jjakub commented Feb 14, 2012

Added to both SBJsonWriter and SBJsonStreamWriter.

stig commented on a911b10 Feb 16, 2012

Code looks good. Is it necessary to add so much test data though?

Owner

jjakub replied Feb 16, 2012

Absolutely not. I've just committed removal of most of them.

Removed unnecessary test data.
Signed-off-by: Jakub Jelonek <jackny+github@gmail.com>
Owner

stig commented Feb 16, 2012

Thanks. Can you also rename the property from comparator to sortKeysComparator so it's a bit more obvious what the comparator is for?

Jakub Jelonek added some commits Feb 16, 2012

Changed expectations of remaining tests.
Signed-off-by: Jakub Jelonek <jackny+github@gmail.com>
Renamed 'comparator' to 'sortKeysComparator'
Signed-off-by: Jakub Jelonek <jackny+github@gmail.com>
Contributor

jjakub commented Feb 16, 2012

Good idea. Done.

stig added a commit that referenced this pull request Feb 16, 2012

Merge pull request #122 from jjakub/master
Added an optional NSComparator to be used when sorting the output JSON.

@stig stig merged commit 5753adb into stig:master Feb 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment