CatchInvalid Date error and display given value instead
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it could be worth to catch this error and display given timestamp instead of showing nothing 🤔 |
|
Nice catch @marcoroth! Thanks 🙏 Could your please update the readme too? |
Update README with the reflected changes
|
Sure! I updated the README and added a catch block in the controller which will show the given value on a parse error. Previously it looked like this: Now it looks like this: It's not perfect, but it's better than showing nothing. |
marcoroth
changed the title
Invalid Date errorInvalid Date error and display given value instead
|
thanks @marcoroth!! Will merge tomorrow 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @guillaumebriday,
It seems like that some browsers see
2018-01-30 09:00as an invalid date.Technically speaking it's not a valid ISO 8601 timestamp. But it seems that some browsers are somewhat generous to treat it as a valid timestamp.
However, this PR fixes the timestamp and shows the given input on a validation error! 😊