Set controller parameter type of all use functions to Controller

[marcoroth]

Before:

When using stimulus-use with TypeScript it complains if you pass in a regular controller into a use function which had the sub-controller as the argument type.

The type for the first argument was not consistent over all the use functions, half of them were Controller (which is the "right" way) and the other half was [Name]ComposableController (or similar).

Since this is just an issue when using TypeScript in the host-application it probably went unnoticed until now.

function useIdle(controller: IdleComposableController, ...) {
  // ...
}

export default class extends Controller {
  connect() {
    useIdle(this)
    // ^^^^^^^^^^
    // Argument of type 'this' is not assignable to parameter of type 'IdleComposableController'.
    // Property 'isIdle' is missing in type 'default' but required in type 'IdleComposableController'.
  }
}

After:

This PR changes all use functions to take a regular Controller as the first argument and casts it to the sub-type in the function body so that the rest of the function can operate on the casted controller.

function useIdle(composableController: Controller, ...) {
  const controller = composableController as IdleComposableController
  // ...
}

export default class extends Controller {
  connect() {
    useIdle(this)
  }
}

I'm not super happy with the name composableController as the first argument name. If you have any better ideas let me know.

Resolves #213

[gjtorikian]

@marcoroth Any chance for a merge and release? Thanks!

[marcoroth]

@marcoroth Any chance for a merge and release? Thanks!

Hey @gjtorikian, yes! I want to cut a new release this week, including this PR.

[marcoroth]

Released as 0.51.0

[gjtorikian]

Thank you!