cover edge case with missing element aborting reflex due to selector …

…memory
stimulusreflex · Oct 25, 2021 · c963153 · c963153
1 parent 54f66d1
commit c963153
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/javascript/callbacks.js b/javascript/callbacks.js
@@ -78,7 +78,8 @@ const afterDOMUpdate = event => {
     )
   )
 
-  CableReady.perform(reflex.piggybackOperations)
+  if (reflex.piggybackOperations.length)
+    CableReady.perform(reflex.piggybackOperations)
 }
 
 const routeReflexEvent = event => {
@@ -120,7 +121,8 @@ const routeReflexEvent = event => {
     )
   )
 
-  CableReady.perform(reflex.piggybackOperations)
+  if (reflex.piggybackOperations.length)
+    CableReady.perform(reflex.piggybackOperations)
 }
 
 const nothing = (event, payload, promise, reflex, reflexElement) => {

diff --git a/lib/stimulus_reflex/broadcasters/nothing_broadcaster.rb b/lib/stimulus_reflex/broadcasters/nothing_broadcaster.rb
@@ -6,6 +6,7 @@ def broadcast(_, data)
       operations << ["document", :dispatch_event]
       cable_ready.dispatch_event(
         name: "stimulus-reflex:morph-nothing",
+        selector: nil,
         payload: payload,
         stimulus_reflex: data.merge(morph: to_sym)
       ).broadcast