Skip to content

Commit

Permalink
Updated gemspec to specific Rails gems (#568)
Browse files Browse the repository at this point in the history
* Updated gemspec to specific Rails gems

Most apps don't require the full suite of Rails gems, and can avoid
installing them to save CI and deploy time. This gem, however, had a
dependency on the Rails meta-gem which ended up installing them all
anyways.

Instead, we can limit it to only the Rails gems that we directly depend upon.

* We use Action View, too

* Update Gemfile.lock

Co-authored-by: leastbad <38150464+leastbad@users.noreply.github.com>
  • Loading branch information
paul and leastbad committed Jan 5, 2022
1 parent a9a4a1d commit d46ecb0
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 6 deletions.
8 changes: 6 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ PATH
remote: .
specs:
stimulus_reflex (3.5.0.pre8)
actioncable (>= 5.2)
actionpack (>= 5.2)
actionview (>= 5.2)
activesupport (>= 5.2)
cable_ready (= 5.0.0.pre8)
nokogiri
rack
rails (>= 5.2)
redis

GEM
Expand Down Expand Up @@ -256,9 +259,10 @@ DEPENDENCIES
mocha
pry
pry-nav
rails (>= 5.2)
rake
standardrb (~> 1.0)
stimulus_reflex!

BUNDLED WITH
2.2.31
2.2.33
14 changes: 10 additions & 4 deletions stimulus_reflex.gemspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

require File.expand_path("../lib/stimulus_reflex/version", __FILE__)
require File.expand_path("lib/stimulus_reflex/version", __dir__)

Gem::Specification.new do |gem|
gem.name = "stimulus_reflex"
Expand Down Expand Up @@ -32,17 +32,23 @@ Gem::Specification.new do |gem|
gem.files = Dir["app/**/*", "lib/**/*", "bin/*", "[A-Z]*"]
gem.test_files = Dir["test/**/*.rb"]

gem.add_dependency "rack"
rails_version = ">= 5.2"
gem.add_dependency "actioncable", rails_version
gem.add_dependency "actionpack", rails_version
gem.add_dependency "actionview", rails_version
gem.add_dependency "activesupport", rails_version

gem.add_dependency "cable_ready", "5.0.0.pre8"
gem.add_dependency "nokogiri"
gem.add_dependency "rails", ">= 5.2"
gem.add_dependency "rack"
gem.add_dependency "redis"
gem.add_dependency "cable_ready", "5.0.0.pre8"

gem.add_development_dependency "bundler", "~> 2.0"
gem.add_development_dependency "github_changelog_generator"
gem.add_development_dependency "mocha"
gem.add_development_dependency "pry"
gem.add_development_dependency "pry-nav"
gem.add_development_dependency "rails", rails_version
gem.add_development_dependency "rake"
gem.add_development_dependency "standardrb", "~> 1.0"
end

0 comments on commit d46ecb0

Please sign in to comment.