Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditional operator breaks webpack in some cases #587

Merged
merged 1 commit into from Jun 6, 2022

Conversation

leastbad
Copy link
Contributor

@leastbad leastbad commented Jun 5, 2022

Type of PR (feature, enhancement, bug fix, etc.)

Bug fix

Description

Modifies elementToXPath to not use optional chaining operator.

Why should this be added

Some permutations of Webpacker choke on compiled SR bundles that include ?. syntax for safe navigation. While it's possible to mitigate this with the addition of an acorn resolution, the single use of the operator is not enough of a benefit to justify significant further exploration at this time.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing
  • This is not a documentation update

Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️

@leastbad leastbad added bug Something isn't working javascript Pull requests that update Javascript code labels Jun 5, 2022
@leastbad leastbad added this to the 3.5 milestone Jun 5, 2022
@leastbad leastbad self-assigned this Jun 5, 2022
@leastbad leastbad merged commit ead4bab into stimulusreflex:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant