Call initial setupDeclarativeReflexes() on document.readyState === 'complete'
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
commented
Aug 20, 2022
marcoroth
changed the title
setupDeclarativeReflexes() on document.readystatechangesetupDeclarativeReflexes() on document.readyState === 'complete'
|
Thank you for following up with good research! |
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Bug Fix
Description
This improves the reliability when using Importmaps, so that we can be sure that the DOM is setup properly, so the
setupDeclarativeReflexes()function can be called in the right order.Additionally we export the
setupDeclarativeReflexes()so users can call this function manually if needed, i.e. if they have a specific load order/setup.Why should this be added
Improves the reliability when using StimulusReflex with Importmaps.
Thanks to @matheau for reporting this and providing their work-around.
Checklist