Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generator file name references #644

Merged
merged 1 commit into from Mar 13, 2023
Merged

fix: Generator file name references #644

merged 1 commit into from Mar 13, 2023

Conversation

julianrubisch
Copy link
Contributor

Bug Fix

Description

Fixed the generator's references to template files, which were broken.

I haven't currently tested this against the installer, though.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

@julianrubisch julianrubisch added bug Something isn't working ruby Pull requests that update Ruby code labels Mar 13, 2023
@julianrubisch julianrubisch self-assigned this Mar 13, 2023
@netlify
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for stimulusreflex ready!

Name Link
🔨 Latest commit be5c60f
🔍 Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/640f0ce027abe1000818b798
😎 Deploy Preview https://deploy-preview-644--stimulusreflex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good to me! It works for both invoking the generator directly or when generating the example through the installer!

@julianrubisch julianrubisch merged commit 7bac7fc into main Mar 13, 2023
@julianrubisch julianrubisch deleted the fix-generator branch March 13, 2023 12:04
@@ -66,7 +66,6 @@ class <%= class_name %>Reflex < ApplicationReflex
<%- actions.each do |action| -%>
def <%= action %>
end
<%= "\n" unless action == actions.last -%>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julianrubisch did you remove this by accident?
Screenshot 2023-03-13 at 15 19 35

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no, because it resulted in a dangling indentation for the last end.

might have to have another look at that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants