Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to VersionMismatchError after namespace change #665

Merged
merged 2 commits into from May 31, 2023

Conversation

Matt-Yorkley
Copy link
Contributor

@Matt-Yorkley Matt-Yorkley commented May 31, 2023

Bug fix

Description

This reference to StimulusReflex::Reflex::VersionMismatchError in StimulusReflex::Channel is using an old namespace that was changed recently to StimulusReflex::VersionMismatchError.

Why should this be added

Fixes #664 reported by @obie, additional discussion here: https://discord.com/channels/629472241427415060/733725826411135107/1113306088796864615

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for stimulusreflex ready!

Name Link
🔨 Latest commit ccf4387
🔍 Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/64777c31d7499d00094f204a
😎 Deploy Preview https://deploy-preview-665--stimulusreflex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for promptly fixing this, @Matt-Yorkley!

app/channels/stimulus_reflex/channel.rb Outdated Show resolved Hide resolved
Co-authored-by: Marco Roth <marco.roth@intergga.ch>
Copy link
Member

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marcoroth marcoroth merged commit 52aa993 into stimulusreflex:main May 31, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HEAD and most of the latest releases are broken, references an undefined exception
2 participants