fix build

stinos · Feb 6, 2024 · 85c11b4 · 85c11b4
1 parent 851f746
commit 85c11b4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/ports_windows.yml b/.github/workflows/ports_windows.yml
@@ -73,9 +73,11 @@ jobs:
             </ClCompile>
           </ItemDefinitionGroup>
         </Project>
-        '@ | Set-Content ports\windows\msvc\userignore.props
+        '@ | Set-Content ports\windows\msvc\user.props
+    - name: Build micropython.dll
+      run: msbuild ports\windows\micropythoncore.vcxproj -maxcpucount -property:Configuration=${{ matrix.configuration }} -property:Platform=${{ matrix.platform }} -property:PyVariant=${{ matrix.variant }} 
     - name: Build micropython.exe
-      run: msbuild ports\windows\micropythoncore.vcxproj;ports\windows\micropython.vcxproj -maxcpucount -property:Configuration=${{ matrix.configuration }} -property:Platform=${{ matrix.platform }} -property:PyVariant=${{ matrix.variant }} 
+      run: msbuild ports\windows\micropython.vcxproj -maxcpucount -property:Configuration=${{ matrix.configuration }} -property:Platform=${{ matrix.platform }} -property:PyVariant=${{ matrix.variant }} 
     - name: Get micropython.exe path
       id: get_path
       run: |

diff --git a/ports/windows/msvc/common.props b/ports/windows/msvc/common.props
@@ -42,7 +42,8 @@
     <QstrDependencies Include="$(PyVariantDir)mpconfigvariant.h"/>
   </ItemGroup>
 
-  <!-- Helper for getting resulting executable path since it depends on other properties. -->
+  <!-- Helper for getting resulting executable path since it depends on other properties.
+       Note: recent msbuild versions don't need this, equivalent is msbuild -getProperty:TargetPath. -->
   <Target Name="ShowTargetPath">
     <Message Text="$(TargetPath)" Importance="high"/>
   </Target>