Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(duplicate): preserve options as well as accept overrides #1234

Merged
merged 2 commits into from
Jan 30, 2023
Merged

fix(duplicate): preserve options as well as accept overrides #1234

merged 2 commits into from
Jan 30, 2023

Conversation

erictheswift
Copy link
Contributor

fixes #1207

stipsan
stipsan approved these changes Jan 30, 2023
View reviewed changes
Copy link
Owner

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! ✨

@stipsan
Copy link
Owner

stipsan commented Jan 30, 2023

Damn, that codeclimate integration is just causing so much trouble these days just ignore it we can merge 😅

@stipsan stipsan merged commit 284f711 into stipsan:main Jan 30, 2023
@github-actions
Copy link
Contributor

🎉 This PR is included in version 8.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stipsan stipsan stipsan approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.duplicate() does not accept overrides as well as loses options
2 participants
@erictheswift @stipsan