Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make unsupported commands writable #1301

Merged
merged 2 commits into from
Aug 13, 2023
Merged

fix: Make unsupported commands writable #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c73b014
fix: Make unsupported commands writable
marikaner Aug 8, 2023
50a4930
Fix lint
marikaner Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ class RedisMock extends EventEmitter {
)}, please check the full list over mocked commands: ${docsLink}`
)
},
writable: false,
writable: true,
})
}
})
Expand Down
8 changes: 8 additions & 0 deletions test/functional/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,12 @@ describe('commands', () => {
`"Unsupported command: "debugBuffer", please check the full list over mocked commands: https://github.com/stipsan/ioredis-mock/blob/main/compat.md#supported-commands-"`
)
})

test('unsupported commands should be writable', () => {
const redis = new Redis()
expect(() => {
redis.debug = () => 'DEBUG'
}).not.toThrow()
expect(redis.debug()).toEqual('DEBUG')
})
})