Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support LIMIT in zrangebyscore (#918) #919

Merged
merged 1 commit into from May 20, 2020
Merged

Conversation

mishan
Copy link
Contributor

@mishan mishan commented Feb 11, 2020

No description provided.

@codeclimate
Copy link

codeclimate bot commented Feb 11, 2020

Code Climate has analyzed commit b16322e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 97.5% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.7% (0.0% change).

View more on Code Climate.

@mishan
Copy link
Contributor Author

mishan commented Feb 11, 2020

@stipsan The build failure doesn't appear to be related to my changes. One of them is complaining about nodejs version, another is trying to push something to my fork of your repo (which I made so I can make this PR :) )

@barakharizima
Copy link

@mishan just reminding that if you get the chance to add the same support on the following commands: zrevrangebyscore, zrevrangebylex, zrangebylex which support LIMIT option as well, that would be awesome!

@mishan
Copy link
Contributor Author

mishan commented Apr 13, 2020

@barakharizima done for zrevrangebyscore

@stipsan stipsan merged commit 533a93d into stipsan:master May 20, 2020
@stipsan
Copy link
Owner

stipsan commented May 20, 2020

🎉 This PR is included in version 4.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants